Re: [PATCH] eeprom: Deprecate the legacy eeprom driver

[Jean Delvare <jdelvare@suse.de>]

Hi Greg,

On Wed, 4 Sep 2019 09:57:29 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 02, 2019 at 10:48:38AM +0200, Jean Delvare wrote:
> > Time has come to get rid of the old eeprom driver. The at24 driver
> > should be used instead. So mark the eeprom driver as deprecated and
> > give users some time to migrate. Then we can remove the legacy
> > eeprom driver completely.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/misc/eeprom/Kconfig |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)  
> 
> You might also want to add a big printk() message when the driver is
> loaded that it shouldn't be used.

Good idea, although unfortunately this means expanding
module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe().
Or even just a dev_warn() there to really spam the kernel log in a very
visible way.

Would you prefer a v2 of this patch including that change, or a
separate, incremental patch?

Thanks,
-- 
Jean Delvare
SUSE L3 Support