From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAC5C43331 for ; Fri, 6 Sep 2019 16:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5692F20838 for ; Fri, 6 Sep 2019 16:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394878AbfIFQzf (ORCPT ); Fri, 6 Sep 2019 12:55:35 -0400 Received: from mga02.intel.com ([134.134.136.20]:11171 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393211AbfIFQzc (ORCPT ); Fri, 6 Sep 2019 12:55:32 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 09:55:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,473,1559545200"; d="scan'208";a="267414818" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 06 Sep 2019 09:55:28 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i6HWB-0002Ld-Cm; Fri, 06 Sep 2019 19:55:27 +0300 Date: Fri, 6 Sep 2019 19:55:27 +0300 From: Andy Shevchenko To: Arnd Bergmann Cc: Jonathan Cameron , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alexios Zavras , Colin Ian King , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] Revert "iio: hid-sensor-attributes: Convert to use int_pow()" Message-ID: <20190906165527.GW2680@smile.fi.intel.com> References: <20190906154609.2421410-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906154609.2421410-1-arnd@arndb.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2019 at 05:45:55PM +0200, Arnd Bergmann wrote: > The change to use the generic int_pow instead of the private version > caused a number of build issues on 32-bit architectures and makes > it generally less efficient because of the 64-bit math: > > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_samp_freq_value': > hid-sensor-attributes.c:(.text+0x29c): undefined reference to `__aeabi_uldivmod' > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_read_raw_hyst_value': > hid-sensor-attributes.c:(.text+0x420): undefined reference to `__aeabi_uldivmod' > hid-sensor-attributes.c:(.text+0x448): undefined reference to `__aeabi_uldivmod' > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_raw_hyst_value': > hid-sensor-attributes.c:(.text+0x570): undefined reference to `__aeabi_uldivmod' > > There is probably a nicer solution to this, but for the moment, > the revert makes it compile again. > > Fixes: 473d12f7638c ("iio: hid-sensor-attributes: Convert to use int_pow()") Does the fix [1] works for you? [1]: https://lore.kernel.org/linux-iio/6851830d050ddb2f27d1e6969755ee4f3293d37c.camel@intel.com/ -- With Best Regards, Andy Shevchenko