* Status of led-backlight driver
@ 2019-09-07 10:07 Pavel Machek
2019-09-09 11:14 ` Daniel Thompson
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2019-09-07 10:07 UTC (permalink / raw)
To: kernel list, linux-arm-kernel, linux-omap, tony, sre, nekit1000,
mpartap, merlijn, tomi.valkeinen, jjhiblot
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
Hi!
I don't see the LED-backlight driver in -next. Could it be pushed? It
is one of last pieces to get working backlight on Motorola Droid 4...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Status of led-backlight driver
2019-09-07 10:07 Status of led-backlight driver Pavel Machek
@ 2019-09-09 11:14 ` Daniel Thompson
2019-09-09 11:46 ` Jean-Jacques Hiblot
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Thompson @ 2019-09-09 11:14 UTC (permalink / raw)
To: Pavel Machek
Cc: kernel list, linux-arm-kernel, linux-omap, tony, sre, nekit1000,
mpartap, merlijn, tomi.valkeinen, jjhiblot
On Sat, Sep 07, 2019 at 12:07:27PM +0200, Pavel Machek wrote:
> Hi!
>
> I don't see the LED-backlight driver in -next. Could it be pushed? It
> is one of last pieces to get working backlight on Motorola Droid 4...
Sorry, I dropped the ball on this and was therefore rather late
reviewing this patchset.
Assuming I have read the code correctly I think there are some
problems with the max_brightness handling in the backlight code.
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Status of led-backlight driver
2019-09-09 11:14 ` Daniel Thompson
@ 2019-09-09 11:46 ` Jean-Jacques Hiblot
2019-09-09 13:04 ` Daniel Thompson
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Jacques Hiblot @ 2019-09-09 11:46 UTC (permalink / raw)
To: Daniel Thompson, Pavel Machek
Cc: kernel list, linux-arm-kernel, linux-omap, tony, sre, nekit1000,
mpartap, merlijn, tomi.valkeinen
Hi Daniel,
On 09/09/2019 13:14, Daniel Thompson wrote:
> On Sat, Sep 07, 2019 at 12:07:27PM +0200, Pavel Machek wrote:
>> Hi!
>>
>> I don't see the LED-backlight driver in -next. Could it be pushed? It
>> is one of last pieces to get working backlight on Motorola Droid 4...
> Sorry, I dropped the ball on this and was therefore rather late
> reviewing this patchset.
>
> Assuming I have read the code correctly I think there are some
> problems with the max_brightness handling in the backlight code.
Can you comment this? I'll be happy to fix the problem.
Reading the v4 again, I noticed that that I still had not removed the
brightness scaling. Is that the problem ?
JJ
>
> Daniel.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Status of led-backlight driver
2019-09-09 11:46 ` Jean-Jacques Hiblot
@ 2019-09-09 13:04 ` Daniel Thompson
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2019-09-09 13:04 UTC (permalink / raw)
To: Jean-Jacques Hiblot
Cc: Pavel Machek, kernel list, linux-arm-kernel, linux-omap, tony,
sre, nekit1000, mpartap, merlijn, tomi.valkeinen
On Mon, Sep 09, 2019 at 01:46:39PM +0200, Jean-Jacques Hiblot wrote:
> Hi Daniel,
>
> On 09/09/2019 13:14, Daniel Thompson wrote:
> > On Sat, Sep 07, 2019 at 12:07:27PM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > I don't see the LED-backlight driver in -next. Could it be pushed? It
> > > is one of last pieces to get working backlight on Motorola Droid 4...
> > Sorry, I dropped the ball on this and was therefore rather late
> > reviewing this patchset.
> >
> > Assuming I have read the code correctly I think there are some
> > problems with the max_brightness handling in the backlight code.
>
> Can you comment this? I'll be happy to fix the problem.
I did that before replying to the nudges. See:
https://lore.kernel.org/linux-leds/20190909095304.67ehnpg6gckwpno4@holly.lan/
> Reading the v4 again, I noticed that that I still had not removed the
> brightness scaling. Is that the problem ?
Yes (plus a couple of nits).
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-09 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-07 10:07 Status of led-backlight driver Pavel Machek
2019-09-09 11:14 ` Daniel Thompson
2019-09-09 11:46 ` Jean-Jacques Hiblot
2019-09-09 13:04 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox