From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sandro Volery <sandro@volery.com>
Cc: rspringer@google.com, toddpoynor@google.com,
benchan@chromium.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed parentheses malpractice in apex_driver.c
Date: Sat, 7 Sep 2019 17:52:10 +0300 [thread overview]
Message-ID: <20190907145210.GB20699@kadam> (raw)
In-Reply-To: <C3F8799B-2CFE-4F3B-A01A-DFDF248BA01F@volery.com>
On Sat, Sep 07, 2019 at 04:48:21PM +0200, Sandro Volery wrote:
> > Joe's comments are, of course, correct as well.
> >
> > regards,
> > dan carpenter
> >
>
> I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda bad tho if I just apply his work and send it in?
Don't feel bad. Just do it. Give him credit in the commit message if
you want. "Thanks to Joe Perches for his help."
I sometimes give people word for word patches and they don't copy it
exactly and I wonder if this is why... My exact patch was the best one.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-07 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 18:38 [PATCH] Fixed parentheses malpractice in apex_driver.c volery
2019-09-06 20:55 ` Joe Perches
2019-09-07 14:38 ` Dan Carpenter
2019-09-07 14:48 ` Sandro Volery
2019-09-07 14:52 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-07 15:34 Sandro Volery
2019-09-07 15:44 ` Joe Perches
2019-09-07 15:56 ` Sandro Volery
2019-09-07 16:08 ` Joe Perches
2019-09-07 16:12 ` Sandro Volery
2019-09-09 16:14 ` Joe Perches
2019-09-09 16:36 ` Sandro Volery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907145210.GB20699@kadam \
--to=dan.carpenter@oracle.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sandro@volery.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox