Re: [PATCH 4.19 19/57] Bluetooth: hidp: Let hidp_send_message return number of queued bytes

Pavel Machek
2019-09-09T12:15:59Z

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Hi!

> [ Upstream commit 48d9cc9d85dde37c87abb7ac9bbec6598ba44b56 ]
>
> Let hidp_send_message return the number of successfully queued bytes
> instead of an unconditional 0.
>
> With the return value fixed to 0, other drivers relying on hidp, such as
> hidraw, can not return meaningful values from their respective
> implementations of write(). In particular, with the current behavior, a
> hidraw device's write() will have different return values depending on
> whether the device is connected via USB or Bluetooth, which makes it
> harder to abstract away the transport layer.

So, does this change any actual behaviour?

Is it fixing a bug, or is it just preparation for a patch that is not
going to make it to stable?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]