From: "Valentin Vidić" <vvidic@valentin-vidic.from.hr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: exfat: add millisecond support
Date: Sun, 8 Sep 2019 16:51:31 +0000 [thread overview]
Message-ID: <20190908165131.GC7664@valentin-vidic.from.hr> (raw)
In-Reply-To: <20190908164040.GA8362@kroah.com>
On Sun, Sep 08, 2019 at 05:40:40PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Sep 08, 2019 at 04:10:15PM +0000, Valentin Vidic wrote:
> > void fat_set_entry_time(struct dentry_t *p_entry, struct timestamp_t *tp,
> > u8 mode)
> > {
> > + u8 ms;
> > u16 t, d;
> > struct dos_dentry_t *ep = (struct dos_dentry_t *)p_entry;
> >
> > t = (tp->hour << 11) | (tp->min << 5) | (tp->sec >> 1);
> > d = (tp->year << 9) | (tp->mon << 5) | tp->day;
> >
> > + ms = tp->millisec;
> > + if (tp->sec & 1) {
> > + ms += 1000;
> > + }
>
> checkpatch didn't complain about this { } not being needed?
>
> Same in other parts of this patch, please fix up.
No warnings from checkpatch here, will update the code.
--
Valentin
next prev parent reply other threads:[~2019-09-08 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 16:10 [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Valentin Vidic
2019-09-08 16:10 ` [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms Valentin Vidic
2019-09-08 16:41 ` Greg Kroah-Hartman
2019-09-09 0:19 ` Valdis Klētnieks
2019-09-09 6:14 ` Valentin Vidić
2019-09-08 16:10 ` [PATCH v2 3/3] staging: exfat: add millisecond support Valentin Vidic
2019-09-08 16:40 ` Greg Kroah-Hartman
2019-09-08 16:51 ` Valentin Vidić [this message]
2019-09-08 16:45 ` [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908165131.GC7664@valentin-vidic.from.hr \
--to=vvidic@valentin-vidic.from.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox