From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573B8C4332F for ; Sun, 8 Sep 2019 16:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BD7321479 for ; Sun, 8 Sep 2019 16:51:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=valentin-vidic.from.hr header.i=@valentin-vidic.from.hr header.b="o3OMR4q6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730014AbfIHQvf (ORCPT ); Sun, 8 Sep 2019 12:51:35 -0400 Received: from valentin-vidic.from.hr ([94.229.67.141]:35115 "EHLO valentin-vidic.from.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbfIHQve (ORCPT ); Sun, 8 Sep 2019 12:51:34 -0400 X-Virus-Scanned: Debian amavisd-new at valentin-vidic.from.hr Received: by valentin-vidic.from.hr (Postfix, from userid 1000) id 94489214; Sun, 8 Sep 2019 16:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=valentin-vidic.from.hr; s=2017; t=1567961491; bh=mF+4NLAhuyJUGqzq9vSqZm83S4VIa0cpRhn2ECd2y4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o3OMR4q61kLV0E7oGS9ZGieXIIxu3qYyIlhFWo3OXmO73+qb8cGqTR96bm8K/WYTM aV7BbUA/n4mid/lYQJi+YJgrO8o4tTf/b2Te5FUiS6UVhNfoapq8c9cInhhIoBlPVB QdevGiXPsFeODOkwTHoH8Hn3kw3jI5agSyoDzCt7RxbmCFHTQlVgPMwQfsC7VT1DNV zp9QxVGaUsUsL1m3EnT1Oz+yeD1NOFnzIADxeF5E5UnY8j/VuCQBxz7qGe3A5AvGey uO79kDLHzWuyXCacbj3Z8sETEafbUYnKXY3G+xT8uVa35wSUeFv0t5+Hh1XEsN+H26 Q1MeawsruR0dA== Date: Sun, 8 Sep 2019 16:51:31 +0000 From: Valentin =?utf-8?B?VmlkacSH?= To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Valdis Kletnieks , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] staging: exfat: add millisecond support Message-ID: <20190908165131.GC7664@valentin-vidic.from.hr> References: <20190908161015.26000-1-vvidic@valentin-vidic.from.hr> <20190908161015.26000-3-vvidic@valentin-vidic.from.hr> <20190908164040.GA8362@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190908164040.GA8362@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 08, 2019 at 05:40:40PM +0100, Greg Kroah-Hartman wrote: > On Sun, Sep 08, 2019 at 04:10:15PM +0000, Valentin Vidic wrote: > > void fat_set_entry_time(struct dentry_t *p_entry, struct timestamp_t *tp, > > u8 mode) > > { > > + u8 ms; > > u16 t, d; > > struct dos_dentry_t *ep = (struct dos_dentry_t *)p_entry; > > > > t = (tp->hour << 11) | (tp->min << 5) | (tp->sec >> 1); > > d = (tp->year << 9) | (tp->mon << 5) | tp->day; > > > > + ms = tp->millisec; > > + if (tp->sec & 1) { > > + ms += 1000; > > + } > > checkpatch didn't complain about this { } not being needed? > > Same in other parts of this patch, please fix up. No warnings from checkpatch here, will update the code. -- Valentin