Re: [PATCH 4/9] select: Micro-optimise __estimate_accuracy()

Dmitry Safonov
2019-09-19T14:25:59Z

On 9/19/19 3:05 PM, Cyrill Gorcunov wrote:
[..]
>> diff --git a/fs/select.c b/fs/select.c
>> index 12cdefd3be2d..2477c202631e 100644
>> --- a/fs/select.c
>> +++ b/fs/select.c
>> @@ -51,15 +51,14 @@
>>
>> static long __estimate_accuracy(ktime_t slack)
>> {
>> - int divfactor = 1000;
>> -
>> if (slack < 0)
>> return 0;
>
> Btw, don't you better use <= here?
>

Good point, will do for v2.

Thanks,
Dmitry