From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256DCC3A5A2 for ; Tue, 10 Sep 2019 09:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEE0121479 for ; Tue, 10 Sep 2019 09:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568107879; bh=ByHxJweeMie6TMOS1XtfpI2Bl4aY7AzmSS2JVGOncCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jckY1ovFrjUtAY+QpLU9rm/yvhxVHiFlec8sGyJqdng40ElIsOMBZvb0rOA6UIbxo bCEQ7kGZQl42ujl7Gs2uH49GtxYNNTWCYcwhusqVBVvGxAWBZHZ9HdkvYHCB1zrL02 gbUqkXTjPBvm0Qz7kOMKoFGc94aOCkDLppzb4hGw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389954AbfIJJbS (ORCPT ); Tue, 10 Sep 2019 05:31:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:50362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731426AbfIJJbR (ORCPT ); Tue, 10 Sep 2019 05:31:17 -0400 Received: from localhost (110.8.30.213.rev.vodafone.pt [213.30.8.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B97D20863; Tue, 10 Sep 2019 09:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568107877; bh=ByHxJweeMie6TMOS1XtfpI2Bl4aY7AzmSS2JVGOncCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rlpXTHURU+b85uwVk+RwfKzay7X+Gc7jBTE/BAWRTFvBA+Myr9Aa8r32CoK+QVtz/ JLbqRI7zKn49ebbbkeaOcJ/7TN0d4rQLGCMG/QOQedWfGSLN5N/laSoSv+6HOu7yyg JM23S7oi3T8AmryTgRI8l8KjG3Ju5IU0uTfWGA1k= Date: Tue, 10 Sep 2019 10:31:14 +0100 From: Greg KH To: Yunsheng Lin Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, mhocko@kernel.org, linuxarm@huawei.com Subject: Re: [PATCH] driver core: ensure a device has valid node id in device_add() Message-ID: <20190910093114.GA19821@kroah.com> References: <1568009063-77714-1-git-send-email-linyunsheng@huawei.com> <20190909095347.GB6314@kroah.com> <9598b359-ab96-7d61-687a-917bee7a5cd9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9598b359-ab96-7d61-687a-917bee7a5cd9@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 02:43:32PM +0800, Yunsheng Lin wrote: > On 2019/9/9 17:53, Greg KH wrote: > > On Mon, Sep 09, 2019 at 02:04:23PM +0800, Yunsheng Lin wrote: > >> Currently a device does not belong to any of the numa nodes > >> (dev->numa_node is NUMA_NO_NODE) when the node id is neither > >> specified by fw nor by virtual device layer and the device has > >> no parent device. > > > > Is this really a problem? > > Not really. > Someone need to guess the node id when it is not specified, right? No, why? Guessing guarantees you will get it wrong on some systems. Are you seeing real problems because the id is not being set? What problem is this fixing that you can actually observe? thanks, greg k-h