Re: [PATCH] driver core: ensure a device has valid node id in device_add()

Greg KH
2019-09-10T09:31:19Z

On Tue, Sep 10, 2019 at 02:43:32PM +0800, Yunsheng Lin wrote:
> On 2019/9/9 17:53, Greg KH wrote:
> > On Mon, Sep 09, 2019 at 02:04:23PM +0800, Yunsheng Lin wrote:
> >> Currently a device does not belong to any of the numa nodes
> >> (dev->numa_node is NUMA_NO_NODE) when the node id is neither
> >> specified by fw nor by virtual device layer and the device has
> >> no parent device.
> >
> > Is this really a problem?
>
> Not really.
> Someone need to guess the node id when it is not specified, right?

No, why? Guessing guarantees you will get it wrong on some systems.

Are you seeing real problems because the id is not being set? What
problem is this fixing that you can actually observe?

thanks,

greg k-h