From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FCA8C3A5A2 for ; Tue, 10 Sep 2019 13:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02914208E4 for ; Tue, 10 Sep 2019 13:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VLTTQqwL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729171AbfIJNJt (ORCPT ); Tue, 10 Sep 2019 09:09:49 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43308 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfIJNJs (ORCPT ); Tue, 10 Sep 2019 09:09:48 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8AD53Gk090352; Tue, 10 Sep 2019 13:09:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=X4keng+SV8htc9lC32w1O4BuTKJIF/NsoIR24KWO7zQ=; b=VLTTQqwLTVsY9lb7KTSQHBL9WkSftyI9Lr1Rwvf+i2LtXfDoIfiAhzCM/2w9eiNaGBiz vM5Xmq4mxN7zigSBscwLNUAUhvA6dr6h4ZgvNXXqGtiTvnqI6NzUfYV8Vsee7lOi5wma RCxeP9J2rmPdME0yqL5yCEGZ5hFZ4K57kFroYxs42TKf8ezo/gV59i2tESLGra46+YK5 x9qjYEjgcxpyXW1GvEs69M7zrjII2hObnm5BmNijxYzRmjMmEwVgNToP8SW9wPCy+9nY FPc7XWaTgaf/XtIHwpBKcUdsmulOUBeq9dsZsCmzDWARxTUnxvN82YaU/J3HEKdW2FUf cw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2uw1jkb9p3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Sep 2019 13:09:43 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8AD8baY062125; Tue, 10 Sep 2019 13:09:42 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2uwqktq3dv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Sep 2019 13:09:42 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x8AD9fAe031237; Tue, 10 Sep 2019 13:09:41 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Sep 2019 06:09:41 -0700 Date: Tue, 10 Sep 2019 16:09:35 +0300 From: Dan Carpenter To: Colin Ian King Cc: "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , Valdis Kletnieks , "linux-kernel@vger.kernel.org" Subject: Re: staging: exfat: issue with FFS_MEDIAERR error return assignment Message-ID: <20190910130934.GE15977@kadam> References: <20190910124443.GD15977@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9375 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909100128 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9375 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909100128 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 01:58:35PM +0100, Colin Ian King wrote: > On 10/09/2019 13:44, Dan Carpenter wrote: > > On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote: > >> Hi, > >> > >> Static analysis on exfat with Coverity has picked up an assignment of > >> FFS_MEDIAERR that gets over-written: > >> > >> > >> 1750 if (is_dir) { > >> 1751 if ((fid->dir.dir == p_fs->root_dir) && > >> 1752 (fid->entry == -1)) { > >> 1753 if (p_fs->dev_ejected) > > > > Idealy we would have both a filename and a function name but this email > > doesn't have either so no one knows what code you are talking about. :P > > Oops, my bad. > > drivers/staging/exfat/exfat_super.c ffsWriteStat() Yes, your solution is correct. regards, dan carpenter