Re: [PATCH 08/11] gpiolib: of: tease apart of_find_gpio()

Andy Shevchenko
2019-09-11T17:10:22Z

On Wed, Sep 11, 2019 at 12:52:12AM -0700, Dmitry Torokhov wrote:
> Tease apart of_find_gpio() into common function that works on the
> firmware node, and a fallback handler that works on the device
> structure, so that we can later use of_find_gpio() in
> fwnode_gpiod_get_index().

> + desc = of_find_gpio(dev_fwnode(dev),
> + con_id, idx, &lookupflags);

Couple of parameters can be placed on previous line.

> + if (desc == ERR_PTR(-ENOENT))
> + desc = of_find_gpio_fallback(dev, con_id, idx,
> + &lookupflags);

> +

Do we need extra blank line?

--
With Best Regards,
Andy Shevchenko