Re: [PATCH 06/11] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

Laurent Pinchart
2019-09-23T16:01:00Z

Hi Heikki,

On Mon, Sep 23, 2019 at 06:03:33PM +0300, Heikki Krogerus wrote:
> On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote:
> > Hi Dmitry,
> >
> > (CC'ing Heikki as the original author of software nodes support)
> >
> > Thank you for the patch.
> >
> > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote:
> > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
> > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit
> >
> > s/bit/but/
> >
> > > works with arbitrary firmware node.
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > On a side note, as I'm not very familiar with software nodes, I tried to
> > see how they are to be used, and it seems they are completely
> > undocumented :-( Heikki, is this something that could be fixed ?
>
> OK. I'll start writing API documentation for it.

That's great, thanks ! I'll do my best to review it if you CC me.

--
Regards,

Laurent Pinchart