public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] module: Remove leftover '#undef' from export header
@ 2019-09-11 23:00 Will Deacon
  2019-09-12 13:31 ` Jessica Yu
  0 siblings, 1 reply; 2+ messages in thread
From: Will Deacon @ 2019-09-11 23:00 UTC (permalink / raw)
  To: linux-kernel; +Cc: Will Deacon, Ard Biesheuvel, Jessica Yu

Commit 7290d5809571 ("module: use relative references for __ksymtab
entries") converted the '__put' #define into an assembly macro in
asm-generic/export.h but forgot to remove the corresponding '#undef'.

Remove the leftover '#undef'.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>
---

I spotted this trivial issue when debugging the namespace issue earlier
today, so here's the patch.

 include/asm-generic/export.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
index 294d6ae785d4..153d9c2ee580 100644
--- a/include/asm-generic/export.h
+++ b/include/asm-generic/export.h
@@ -57,7 +57,6 @@ __kcrctab_\name:
 #endif
 #endif
 .endm
-#undef __put
 
 #if defined(CONFIG_TRIM_UNUSED_KSYMS)
 
-- 
2.23.0.237.gc6a4ce50a0-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] module: Remove leftover '#undef' from export header
  2019-09-11 23:00 [PATCH] module: Remove leftover '#undef' from export header Will Deacon
@ 2019-09-12 13:31 ` Jessica Yu
  0 siblings, 0 replies; 2+ messages in thread
From: Jessica Yu @ 2019-09-12 13:31 UTC (permalink / raw)
  To: Will Deacon; +Cc: linux-kernel, Ard Biesheuvel

+++ Will Deacon [12/09/19 00:00 +0100]:
>Commit 7290d5809571 ("module: use relative references for __ksymtab
>entries") converted the '__put' #define into an assembly macro in
>asm-generic/export.h but forgot to remove the corresponding '#undef'.
>
>Remove the leftover '#undef'.
>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Jessica Yu <jeyu@kernel.org>
>Signed-off-by: Will Deacon <will@kernel.org>
>---
>
>I spotted this trivial issue when debugging the namespace issue earlier
>today, so here's the patch.

Applied, thanks for the cleanup!

Jessica


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-12 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-11 23:00 [PATCH] module: Remove leftover '#undef' from export header Will Deacon
2019-09-12 13:31 ` Jessica Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox