From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE9CC49ED7 for ; Fri, 13 Sep 2019 03:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A22520856 for ; Fri, 13 Sep 2019 03:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568345518; bh=xe/JQYqK2joRWmcoEKC69faO00pRfkUSxLsZFzljHx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MyxNql1AgkUxLPWpPBU14BOUHqY9H9wdLH55z8GratLrBX2v/4lPH08RyPn9x+AsQ D9sAFnwmgtMl0DK88U8vm/u+5AamU+qpjwcqWlWsU0Gd+uVELaE6CAI5dFwYUv7Ge4 YGqHBeN4N5A8i/SgH2uc/gtbQFiq0kciACLdi3Rk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbfIMDb4 (ORCPT ); Thu, 12 Sep 2019 23:31:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:58596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfIMDb4 (ORCPT ); Thu, 12 Sep 2019 23:31:56 -0400 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B7E62084D; Fri, 13 Sep 2019 03:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568345515; bh=xe/JQYqK2joRWmcoEKC69faO00pRfkUSxLsZFzljHx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oOgasMqDODc+/kPGQTMrlSa8enwJYrsd2Ov9O9jP0QnVdULOh56TqcyOuZ8hTfVaV Uzjj1aeO59WeNJtEkBmwa9FzGw8T8qXW1sSlEHtScKu8WvdSpwfYfag2sgnjk9lcOI io9N4+DGPlePxXUyAFnEvjFHLvdCBC0pRusMovM8= Date: Fri, 13 Sep 2019 11:31:46 +0800 From: Shawn Guo To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: linux-kernel@vger.kernel.org, Ilya Ledvich , Igor Grinberg , Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/12] ARM: dts: imx7d: cl-som-imx7 imx7d-sbc-imx7: move USB Message-ID: <20190913033145.GG17142@dragon> References: <20190826153800.35400-1-git@andred.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190826153800.35400-1-git@andred.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 26, 2019 at 04:37:49PM +0100, André Draszik wrote: > Whether and which USB port is enabled and how they > are powered is a function of the carrier board, not > of the SoM. Different carrier boards can have different > ports enabled / wired up, and power them differently; > so this should really move into the respective DTS. > > Do so and update the USB power supply to reflect > the actual situation on the sbc-imx7 carrier board. > > Signed-off-by: André Draszik > Cc: Ilya Ledvich > Cc: Igor Grinberg Ilya, Igor, can you have a look at the series? Shawn > Cc: Rob Herring > Cc: Mark Rutland > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 24 ------------------------ > arch/arm/boot/dts/imx7d-sbc-imx7.dts | 13 +++++++++++++ > 2 files changed, 13 insertions(+), 24 deletions(-) > > diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > index 62d5e9a4a781..6f7e85cf0c28 100644 > --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > @@ -22,15 +22,6 @@ > device_type = "memory"; > reg = <0x80000000 0x10000000>; /* 256 MB - minimal configuration */ > }; > - > - reg_usb_otg1_vbus: regulator-vbus { > - compatible = "regulator-fixed"; > - regulator-name = "usb_otg1_vbus"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>; > - enable-active-high; > - }; > }; > > &cpu0 { > @@ -193,13 +184,6 @@ > status = "okay"; > }; > > -&usbotg1 { > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_usbotg1>; > - vbus-supply = <®_usb_otg1_vbus>; > - status = "okay"; > -}; > - > &usdhc3 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc3>; > @@ -278,11 +262,3 @@ > >; > }; > }; > - > -&iomuxc_lpsr { > - pinctrl_usbotg1: usbotg1grp { > - fsl,pins = < > - MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x14 /* OTG PWREN */ > - >; > - }; > -}; > diff --git a/arch/arm/boot/dts/imx7d-sbc-imx7.dts b/arch/arm/boot/dts/imx7d-sbc-imx7.dts > index f8a868552707..aab646903de3 100644 > --- a/arch/arm/boot/dts/imx7d-sbc-imx7.dts > +++ b/arch/arm/boot/dts/imx7d-sbc-imx7.dts > @@ -15,6 +15,14 @@ > / { > model = "CompuLab SBC-iMX7"; > compatible = "compulab,sbc-imx7", "compulab,cl-som-imx7", "fsl,imx7d"; > + > + reg_usb_vbus: regulator-usb-vbus { > + compatible = "regulator-fixed"; > + regulator-name = "usb_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > }; > > &usdhc1 { > @@ -26,6 +34,11 @@ > status = "okay"; > }; > > +&&usbotg1 { > + vbus-supply = <®_usb_vbus>; > + status = "okay"; > +}; > + > &iomuxc { > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > -- > 2.23.0.rc1 >