From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v2] tracing: Be more clever when dumping hex in __print_hex()
Date: Fri, 13 Sep 2019 15:28:26 +0300 [thread overview]
Message-ID: <20190913122826.GP2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190806113352.334d81b9@gandalf.local.home>
On Tue, Aug 06, 2019 at 11:33:52AM -0400, Steven Rostedt wrote:
> On Tue, 6 Aug 2019 18:15:43 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Hex dump as many as 16 bytes at once in trace_print_hex_seq()
> > instead of byte-by-byte approach.
> > + const char *fmt = concatenate ? "%*phN" : "%*ph";
> >
> > + for (i = 0; i < buf_len; i += 16)
> > + trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]);
>
> Cute.
>
> I'll have to wrap my head around it a bit to make sure it's correct.
Anything I need to update here?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-13 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 15:15 [PATCH v2] tracing: Be more clever when dumping hex in __print_hex() Andy Shevchenko
2019-08-06 15:33 ` Steven Rostedt
2019-09-13 12:28 ` Andy Shevchenko [this message]
2019-09-14 23:50 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913122826.GP2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox