From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1EEC49ED7 for ; Fri, 13 Sep 2019 12:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 051C820678 for ; Fri, 13 Sep 2019 12:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729740AbfIMM23 (ORCPT ); Fri, 13 Sep 2019 08:28:29 -0400 Received: from mga04.intel.com ([192.55.52.120]:23157 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728618AbfIMM22 (ORCPT ); Fri, 13 Sep 2019 08:28:28 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 05:28:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,501,1559545200"; d="scan'208";a="210332672" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 13 Sep 2019 05:28:27 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i8kgc-0003RL-8m; Fri, 13 Sep 2019 15:28:26 +0300 Date: Fri, 13 Sep 2019 15:28:26 +0300 From: Andy Shevchenko To: Steven Rostedt Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Rasmus Villemoes Subject: Re: [PATCH v2] tracing: Be more clever when dumping hex in __print_hex() Message-ID: <20190913122826.GP2680@smile.fi.intel.com> References: <20190806151543.86061-1-andriy.shevchenko@linux.intel.com> <20190806113352.334d81b9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806113352.334d81b9@gandalf.local.home> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 06, 2019 at 11:33:52AM -0400, Steven Rostedt wrote: > On Tue, 6 Aug 2019 18:15:43 +0300 > Andy Shevchenko wrote: > > > Hex dump as many as 16 bytes at once in trace_print_hex_seq() > > instead of byte-by-byte approach. > > + const char *fmt = concatenate ? "%*phN" : "%*ph"; > > > > + for (i = 0; i < buf_len; i += 16) > > + trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]); > > Cute. > > I'll have to wrap my head around it a bit to make sure it's correct. Anything I need to update here? -- With Best Regards, Andy Shevchenko