Re: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void

Kalle Valo
2019-09-13T13:37:55Z

zhong jiang <zhongjiang@huawei.com> wrote:

> brcms_c_set_mac do not need return value to cope with different
> cases. And change functon return type to void.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

I just don't see the benefit from changing the function to return void.
And if we ever add error handling to the function we need to change it
back to return int again, which is extra work.

Patch set to Rejected.

--