From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763EAC49ED7 for ; Fri, 13 Sep 2019 13:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49D24206BB for ; Fri, 13 Sep 2019 13:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MnbV2qHM"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FY+xJdkj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391727AbfIMNol (ORCPT ); Fri, 13 Sep 2019 09:44:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60136 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388489AbfIMNol (ORCPT ); Fri, 13 Sep 2019 09:44:41 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 17711607CA; Fri, 13 Sep 2019 13:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568382280; bh=vyt/3hzOSaAAxezkzLOi1iLD8HN1GuNmP4hYAG0W1FA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=MnbV2qHM+bSPAbTmHbg3nNzGX8DE/Q0+tzN/lE933ZItOchPc5uZcPQs5Mz7ATmks JrDztRdcLFwTrmgQK95K4ty+XDlw8/PdsybhmbYwq5NZmwjbO1Dsv06Ix52pF5pcCW dOWdsrKhFzbaOx8HqxpOI+dsAt1RgYMWDIxp4jwI= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8882A602C3; Fri, 13 Sep 2019 13:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568382279; bh=vyt/3hzOSaAAxezkzLOi1iLD8HN1GuNmP4hYAG0W1FA=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=FY+xJdkjqkV26JGjs6bIKRSpXRDCVa6SNEM0zTU+FtViblbDIbmbVNBhMGWqx9gLG r2xJm5zysJeRssGkH0F33b204BuNk+MPyzcB2n2/YWMyfUFqauvNVJaP8XTJKME6nz Bn5RqyFwn9Dq6FS4qDVz1y/o4J6Ri1rLAHgVbPmE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8882A602C3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: rtl8821ae: make array static const and remove redundant assignment From: Kalle Valo In-Reply-To: <20190905150022.3609-1-colin.king@canonical.com> References: <20190905150022.3609-1-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190913134440.17711607CA@smtp.codeaurora.org> Date: Fri, 13 Sep 2019 13:44:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The array channel_all can be make static const rather than populating > it on the stack, this makes the code smaller. Also, variable place > is being initialized with a value that is never read, so this assignment > is redundant and can be removed. > > Before: > text data bss dec hex filename > 118537 9591 0 128128 1f480 realtek/rtlwifi/rtl8821ae/phy.o > > After: > text data bss dec hex filename > 118331 9687 0 128018 1f412 realtek/rtlwifi/rtl8821ae/phy.o > > Saves 110 bytes, (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 569ce0a486fd rtlwifi: rtl8821ae: make array static const and remove redundant assignment -- https://patchwork.kernel.org/patch/11133295/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches