From: Steve Wahl <steve.wahl@hpe.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Steve Wahl <steve.wahl@hpe.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Juergen Gross <jgross@suse.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Jordan Borgner <mail@jordan-borgner.de>,
Feng Tang <feng.tang@intel.com>,
linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>,
russ.anderson@hpe.com, dimitri.sivanich@hpe.com,
mike.travis@hpe.com
Subject: Re: [PATCH] x86/boot/64: Make level2_kernel_pgt pages invalid outside kernel area.
Date: Fri, 13 Sep 2019 10:14:15 -0500 [thread overview]
Message-ID: <20190913151415.GG7834@swahl-linux> (raw)
In-Reply-To: <20190912101917.mbobjvkxhfttxddd@box>
On Thu, Sep 12, 2019 at 01:19:17PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 11, 2019 at 03:08:35PM -0500, Steve Wahl wrote:
> > Thank you for your time looking into this with me!
>
> With all this explanation the original patch looks sane to me.
>
> But I would like to see more information from this thread in the commit
> message and some comments in the code on why it's crucial not to map more
> than needed.
I am working on this.
> I think we also need to make it clear that this is workaround for a broken
> hardware: speculative execution must not trigger a halt.
I think the word broken is a bit loaded here. According to the UEFI
spec (version 2.8, page 167), "Regions that are backed by the physical
hardware, but are not supposed to be accessed by the OS, must be
returned as EfiReservedMemoryType." Our interpretation is that
includes speculative accesses.
I'd lean more toward "tightening of adherence to the spec required by
some particular hardware." Does that work for you?
--> Steve Wahl
--
Steve Wahl, Hewlett Packard Enterprise
next prev parent reply other threads:[~2019-09-13 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 21:29 [PATCH] x86/boot/64: Make level2_kernel_pgt pages invalid outside kernel area Steve Wahl
2019-09-09 8:14 ` Kirill A. Shutemov
2019-09-10 6:18 ` Ingo Molnar
2019-09-10 14:38 ` Steve Wahl
2019-09-10 14:28 ` Steve Wahl
2019-09-11 0:28 ` Kirill A. Shutemov
2019-09-11 20:08 ` Steve Wahl
2019-09-12 10:19 ` Kirill A. Shutemov
2019-09-13 15:14 ` Steve Wahl [this message]
2019-09-16 9:00 ` Kirill A. Shutemov
2019-09-16 14:25 ` Dave Hansen
2019-09-16 17:14 ` Steve Wahl
2019-09-16 22:19 ` Dave Hansen
2019-09-16 16:17 ` Steve Wahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913151415.GG7834@swahl-linux \
--to=steve.wahl@hpe.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dimitri.sivanich@hpe.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@jordan-borgner.de \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=russ.anderson@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox