Re: [PATCH] mips: sgi-ip27: switch from DISCONTIGMEM to SPARSEMEM

Mike Rapoport
2019-09-05T13:32:59Z

On Thu, Sep 05, 2019 at 03:21:50PM +0200, Thomas Bogendoerfer wrote:
> On Thu, 5 Sep 2019 08:47:57 +0300
> Mike Rapoport <rppt@kernel.org> wrote:
>
> > From: Mike Rapoport <rppt@linux.ibm.com>
> >
> > The memory initialization of SGI-IP27 is already half-way to support
> > SPARSEMEM and only a call to sparse_init() was missing. Add it to
> > prom_meminit() and adjust arch/mips/Kconfig to enable SPARSEMEM and
> > SPARSEMEM_EXTREME for SGI-IP27
> >
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > ---
> >
> > Thomas, could you please test this on your Origin machine?
>
> it crashes in sparse_early_usemaps_alloc_pgdat_section(). Since there is
> already a sparse_init() in arch_mem_setup() I removed it from ip27-memory.c.

Oops, missed that.

> With this booting made more progress but I get an unaligned access in
> kernel_init_free_pages().

Can you please share the log?

> My time is a little bit limited today to dig deeper, but testing patches
> is easy.
>
> Thomas.
>
> --
> SUSE Software Solutions Germany GmbH
> HRB 247165 (AG München)
> Geschäftsführer: Felix Imendörffer

--
Sincerely yours,
Mike.