From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CEFC49ED7 for ; Mon, 16 Sep 2019 09:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 310A220650 for ; Mon, 16 Sep 2019 09:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731873AbfIPJTZ (ORCPT ); Mon, 16 Sep 2019 05:19:25 -0400 Received: from mga14.intel.com ([192.55.52.115]:8763 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfIPJTY (ORCPT ); Mon, 16 Sep 2019 05:19:24 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 02:19:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,512,1559545200"; d="scan'208";a="201562648" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 16 Sep 2019 02:19:21 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 16 Sep 2019 12:19:20 +0300 Date: Mon, 16 Sep 2019 12:19:20 +0300 From: Mika Westerberg To: Jethro Beekman Cc: Marek Vasut , Tudor Ambarus , David Woodhouse , Brian Norris , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] mtd: spi-nor: intel-spi: support chips without software sequencer Message-ID: <20190916091920.GS28281@lahna.fi.intel.com> References: <69f4a8e8-7889-8b00-0adc-7faaef6b42e4@fortanix.com> <32ab6570-c3b7-4eec-7a0b-69bc2f7f76dc@fortanix.com> <20190916091157.GR28281@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 09:12:50AM +0000, Jethro Beekman wrote: > On 2019-09-16 11:11, Mika Westerberg wrote: > > Hi, > > > > On Sun, Sep 15, 2019 at 08:41:55PM +0000, Jethro Beekman wrote: > >> Could someone please review this? > >> > >> On 2019-09-04 03:15, Jethro Beekman wrote: > >>> Some flash controllers don't have a software sequencer. Avoid > >>> configuring the register addresses for it, and double check > >>> everywhere that its not accidentally trying to be used. > > > > All the supported types in intel_spi_init() set ->sregs so I don't see > > how we could end up calling functions with that not set properly. Which > > controller we are talking about here? CNL? > > > > Yes, see 2/2. OK, thanks. Please mention that in the commit log as well. The patch itself looks good to me.