From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aliasgar Surti <aliasgar.surti500@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables
Date: Tue, 17 Sep 2019 17:44:32 +0300 [thread overview]
Message-ID: <20190917144432.GB2959@kadam> (raw)
In-Reply-To: <1568730691-954-1-git-send-email-aliasgar.surti500@gmail.com>
On Tue, Sep 17, 2019 at 08:01:31PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> coccicheck reported warning for unneeded variable used.
>
> This patch removes the unneeded variables.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index d1b199e..fa3ffc3 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2428,8 +2428,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
> static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> - int ret = 0;
> - return ret;
> + return 0;
> }
Just get rid of the whole function. Replace the pointer in the function
array with a NULL.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-17 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 14:31 [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables Aliasgar Surti
2019-09-17 14:44 ` Dan Carpenter [this message]
2019-09-18 6:14 ` ABC XYZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917144432.GB2959@kadam \
--to=dan.carpenter@oracle.com \
--cc=aliasgar.surti500@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox