From: Saiyam Doshi <saiyamdoshi.in@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure
Date: Tue, 17 Sep 2019 21:55:08 +0530 [thread overview]
Message-ID: <20190917162508.GB5388@SD> (raw)
In-Reply-To: <f25a406d-9032-5db9-7136-6ff99c02f888@web.de>
On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote:
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/platform_get_irq.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
>
> Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
> be more helpful than the other description variant?
Okay, will update the changelog.
> > if (qup->irq < 0) {
> > - dev_err(qup->dev, "No IRQ defined\n");
> > return qup->irq;
> > }
> How do you think about to omit the curly brackets here after only a single
> statement would be used in the if branch?
Completely missed that! I will update and resend.
-Saiyam
prev parent reply other threads:[~2019-09-17 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 18:58 [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure Saiyam Doshi
2019-09-17 15:28 ` Markus Elfring
2019-09-17 16:25 ` Saiyam Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917162508.GB5388@SD \
--to=saiyamdoshi.in@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=agross@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox