From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A93C4CECE for ; Tue, 17 Sep 2019 16:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 490362171F for ; Tue, 17 Sep 2019 16:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oJ5h3OBh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbfIQQZP (ORCPT ); Tue, 17 Sep 2019 12:25:15 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45055 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfIQQZP (ORCPT ); Tue, 17 Sep 2019 12:25:15 -0400 Received: by mail-pl1-f196.google.com with SMTP id k24so917026pll.11; Tue, 17 Sep 2019 09:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bgljOZg/sNzlCH3RJEuTYnEE1iTvY4pjYoRACNtJrFc=; b=oJ5h3OBhaOR+w9LTwoV08mAgk9zZk060nVry0Q2M30E8rm+D3r/y4zRaUnzE4GPyMj IvYP93wpuqDU5sCtqII+asMTopmOK5l/LcabbWLFZBeWi998ucf4S57rCRR8R+upxGs6 SgmlbXLZmR38Vs8sf1sv3pE9xj8m+FTROUEWhHF41hwMVwcYvgkgbmj0kb5dZn+2DUEK LWwecHOKgMrglfEcYTLqF4KrchJoZ0jIVviM+8nLub5ej0RKNOWErmmgrjTjG5D3w4qM hmnGNdp5chA3uOTDdir+9EuP425fanZ7nhdWBkqy5MS3j0bWQsKv2wOgP0aoy1r3OPKM hx/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bgljOZg/sNzlCH3RJEuTYnEE1iTvY4pjYoRACNtJrFc=; b=U4786Z4SsdDfqPBT+HNbrghLeKFEwvvUnp9085GbzEI/TbeBnQFtV44KQYbxru0+Nz LecpjB9hcwltQF6AgI214gAQLATQVEyryTWrrZlzsgLAIdULjggRDf911ObrN7FE4ZxF GlEO9Jxc3NPWnp5iCkC57/hKHBb83ig0ik6EULVX7uPKq8bLbePjTzfHX2FZCpF90ZFW 5yRVnlmBqoXvdH69RxFyLFraQVU3H6ojgzudlwZaM3c6c6dJKWLkFO1BBVipbX9aZTLx mJVoAZtB4sGs7c9JnHrTzUJ6ZqSiidYRB6+72IEvwrBfDwyxzz7aZJGNNo/ZZ2C/j3ui mqAQ== X-Gm-Message-State: APjAAAUQWWVawqlZuTrLFip2uFXXb0s+5JKcNKwRczicqVnIJdv2mafu jjLyvCwa0yvUZtyd/EheJjOk/jvYgbU= X-Google-Smtp-Source: APXvYqz8jakHTBRwb+1gp8rUMsqSo/5z7PiJPXJLaQyV38Bzag7BMrZO2lSw4oq/sN/MupqStLivrQ== X-Received: by 2002:a17:902:8c92:: with SMTP id t18mr4726014plo.147.1568737514466; Tue, 17 Sep 2019 09:25:14 -0700 (PDT) Received: from SD ([106.222.12.103]) by smtp.gmail.com with ESMTPSA id r186sm4411622pfr.40.2019.09.17.09.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 09:25:13 -0700 (PDT) Date: Tue, 17 Sep 2019 21:55:08 +0530 From: Saiyam Doshi To: Markus Elfring Cc: Andy Gross , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure Message-ID: <20190917162508.GB5388@SD> References: <20190916185857.GA14093@SD> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote: > > The semantic patch that makes this report is available > > in scripts/coccinelle/api/platform_get_irq.cocci. > > > > Found using - http://coccinelle.lip6.fr/ > > Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci” > be more helpful than the other description variant? Okay, will update the changelog. > > if (qup->irq < 0) { > > - dev_err(qup->dev, "No IRQ defined\n"); > > return qup->irq; > > } > How do you think about to omit the curly brackets here after only a single > statement would be used in the if branch? Completely missed that! I will update and resend. -Saiyam