From: Saiyam Doshi <saiyamdoshi.in@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [3/3] i2c: qup: Use devm_platform_ioremap_resource helper
Date: Tue, 17 Sep 2019 22:08:03 +0530 [thread overview]
Message-ID: <20190917163803.GC5388@SD> (raw)
In-Reply-To: <c24065f1-2692-9529-d505-ae639ce5d271@web.de>
On Tue, Sep 17, 2019 at 05:40:14PM +0200, Markus Elfring wrote:
> > Use devm_platform_ioremap_resource helper which wraps
> > platform_get_resource() and devm_ioremap_resource() together.
>
> Can a wording like “Simplify this function implementation by using
> a known wrapper function.” be nicer for this change description?
Okay. I will change as actual change and changelog is almost similar :)
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
>
> Can a tag like “Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci”
> be more helpful than the other description variant?
will update this in changelog and resend this series.
-Saiyam
prev parent reply other threads:[~2019-09-17 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 19:02 [PATCH 3/3] i2c: qup: Use devm_platform_ioremap_resource helper Saiyam Doshi
2019-09-17 15:40 ` [3/3] " Markus Elfring
2019-09-17 16:38 ` Saiyam Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917163803.GC5388@SD \
--to=saiyamdoshi.in@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=agross@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox