From: Al Viro <viro@zeniv.linux.org.uk>
To: kernel test robot <rong.a.chen@intel.com>
Cc: "zhengbin (A)" <zhengbin13@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
lkp@01.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: c25aa432ff: aim9.dir_rtns_1.ops_per_sec -24.5% regression
Date: Wed, 18 Sep 2019 02:23:00 +0100 [thread overview]
Message-ID: <20190918012300.GI1131@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190918001736.GK15734@shao2-debian>
On Wed, Sep 18, 2019 at 08:17:36AM +0800, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed a -24.5% regression of aim9.dir_rtns_1.ops_per_sec due to commit:
>
>
> commit: c25aa432ff56e179bf5414edff3aa430d2b260c0 ("Fix the locking in dcache_readdir() and friends")
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master
... and that, folks, is ->d_lock on the parent. I.e. the original reason for
trying to do the damn thing lockless.
I'd really like to do a lockless variant, properly. First we'd need to sort
the misuses of d_subdirs/d_child, though - there are several outright bugs
in the mainline. And right now it looks like it wants to grow a series of
cleanups in autofs. Oh, well...
prev parent reply other threads:[~2019-09-18 1:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 0:17 c25aa432ff: aim9.dir_rtns_1.ops_per_sec -24.5% regression kernel test robot
2019-09-18 1:23 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918012300.GI1131@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=rong.a.chen@intel.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox