Re: [RFC PATCH v4 0/9] printk: new ringbuffer implementation

Peter Zijlstra
2019-09-06T10:50:11Z

On Fri, Sep 06, 2019 at 07:09:43PM +0900, Sergey Senozhatsky wrote:

> ---
> diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c
> index 139c310049b1..9c73eb6259ce 100644
> --- a/kernel/printk/printk_safe.c
> +++ b/kernel/printk/printk_safe.c
> @@ -103,7 +103,10 @@ static __printf(2, 0) int printk_safe_log_store(struct printk_safe_seq_buf *s,
> if (atomic_cmpxchg(&s->len, len, len + add) != len)
> goto again;
>
> - queue_flush_work(s);
> + if (early_console)
> + early_console->write(early_console, s->buffer + len, add);
> + else
> + queue_flush_work(s);
> return add;
> }

You've not been following along, that generates absolutely unreadable
garbage.