Re: [PATCH v7 09/13] lib/vsprintf: Add a note on re-using %pf or %pF

Petr Mladek
2019-09-24T10:45:53Z

On Wed 2019-09-18 16:34:15, Sakari Ailus wrote:
> Add a note warning of re-use of obsolete %pf or %pF extensions.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> ---
> lib/vsprintf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index b00b57f9f911f..df59818537b52 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -2008,6 +2008,8 @@ static char *kobject_string(char *buf, char *end, void *ptr,
> * - 'S' For symbolic direct pointers (or function descriptors) with offset
> * - 's' For symbolic direct pointers (or function descriptors) without offset
> * - '[Ss]R' as above with __builtin_extract_return_addr() translation
> + * - '[Ff]' Obsolete an now unsupported extension for printing direct pointers
> + * or function descriptors. Be careful when re-using %pf or %pF!

I am not a native speaker but the sentence is hard to parse to me.
Also I miss the word 'symbolic'. IMHO, it described that the output
was a symbol name.

What about something like?

* - '[Ff]' %pf and %pF were obsoleted and later removed in favor of
* %ps and %pS. Be careful when re-using these specifiers.

Best Regards,
Petr