From: Eric Biggers <ebiggers@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: syzbot <syzbot+f39ab8494f6015e62360@syzkaller.appspotmail.com>,
ast@kernel.org, aviadye@mellanox.com, borisp@mellanox.com,
bpf@vger.kernel.org, daniel@iogearbox.net, davejwatson@fb.com,
davem@davemloft.net, ilyal@mellanox.com,
jakub.kicinski@netronome.com, john.fastabend@gmail.com,
kafai@fb.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
songliubraving@fb.com, syzkaller-bugs@googlegroups.com,
yhs@fb.com
Subject: Re: INFO: task hung in cancel_delayed_work_sync
Date: Wed, 18 Sep 2019 22:50:16 -0700 [thread overview]
Message-ID: <20190919055016.GF666@sol.localdomain> (raw)
In-Reply-To: <20190919053620.GG2879@gauss3.secunet.de>
On Thu, Sep 19, 2019 at 07:36:20AM +0200, Steffen Klassert wrote:
> On Wed, Sep 18, 2019 at 10:15:45PM -0700, Eric Biggers wrote:
> >
> > Reproducer involves pcrypt, so probably the pcrypt deadlock again...
> > https://lkml.kernel.org/linux-crypto/20190817054743.GE8209@sol.localdomain/
>
> I'll submit the patch I proposed here in case noone has a better idea
> how to fix this now:
>
> https://lkml.kernel.org/linux-crypto/20190821063704.GM2879@gauss3.secunet.de/
>
> The original patch is from you, I did some modifications to forbid
> pcrypt if an underlying algorithm needs a fallback.
>
> May I leave your 'Signed off' on this patch, or just
> quote that the initial version is from you?
>
Keeping my Signed-off-by is fine, but please leave a note about what you
changed, like:
Signed-off-by: Eric Biggers <ebiggers@google.com>
[SK: also require that the underlying algorithm doesn't need a fallback]
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Also, a nit: in the commit message,
> Fix this by making pcrypt forbid instantiation if pcrypt appears in the
> underlying ->cra_driver_name and if an underlying algorithm needs a
> fallback.
... the word "and" should be "or".
- Eric
prev parent reply other threads:[~2019-09-19 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 10:19 INFO: task hung in cancel_delayed_work_sync syzbot
2019-09-19 5:15 ` Eric Biggers
2019-09-19 5:36 ` Steffen Klassert
2019-09-19 5:50 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919055016.GF666@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ast@kernel.org \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=ilyal@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=steffen.klassert@secunet.com \
--cc=syzbot+f39ab8494f6015e62360@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox