From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F586C49ED7 for ; Thu, 19 Sep 2019 22:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 378982053B for ; Thu, 19 Sep 2019 22:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931953; bh=AB1E/MbgpqzKN9ZmRscBe9uf/LgHfzWk8FJCCK5DZe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dbSpkS7jf/CwmhTu1XQWGDGfcYr4Ade5lGGIz3KZTLlswf30nLJwLsVNKuBSOXbvZ XcbcsiBli4DjqdaBpD+EehfL8M/NqDdsyktNdlMt8So/u4wanKMlitgoKvS/re/qQX Tu4f0yJSIf6QZVvH2R5QCDj+hS07TLibVBytqTuc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436543AbfISWZw (ORCPT ); Thu, 19 Sep 2019 18:25:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394131AbfISWW6 (ORCPT ); Thu, 19 Sep 2019 18:22:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D649B21920; Thu, 19 Sep 2019 22:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568931778; bh=AB1E/MbgpqzKN9ZmRscBe9uf/LgHfzWk8FJCCK5DZe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lg15LTHOAw2NgTFaKehXXmUcPPRCsg9qUwfuHl5UU6oCUOuhyCVnCN9r1V4KsGHc+ VMffYhBvOMxfO3hduwXrltamTxorh5XR1UOi5R8muTClFZki1KlGdWaNIPP1HKDEkG HVU57ZWfn/n89IGh+hny9VlEdw1uPpsjiWqY7bRA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , Marcelo Ricardo Leitner , Neil Horman , "David S. Miller" Subject: [PATCH 4.4 08/56] sctp: use transport pf_retrans in sctp_do_8_2_transport_strike Date: Fri, 20 Sep 2019 00:03:49 +0200 Message-Id: <20190919214747.939647334@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190919214742.483643642@linuxfoundation.org> References: <20190919214742.483643642@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long [ Upstream commit 10eb56c582c557c629271f1ee31e15e7a9b2558b ] Transport should use its own pf_retrans to do the error_count check, instead of asoc's. Otherwise, it's meaningless to make pf_retrans per transport. Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg") Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -505,7 +505,7 @@ static void sctp_do_8_2_transport_strike */ if ((transport->state == SCTP_ACTIVE) && (transport->error_count < transport->pathmaxrxt) && - (transport->error_count > asoc->pf_retrans)) { + (transport->error_count > transport->pf_retrans)) { sctp_assoc_control_transport(asoc, transport, SCTP_TRANSPORT_PF,