From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH] perf tools: Fix segfault in cpu_cache_level__read
Date: Fri, 20 Sep 2019 20:44:33 +0200 [thread overview]
Message-ID: <20190920184433.GB26850@krava> (raw)
In-Reply-To: <20190920182026.GA4865@kernel.org>
On Fri, Sep 20, 2019 at 03:20:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Sep 12, 2019 at 12:52:35PM +0200, Jiri Olsa escreveu:
> > We release wrong pointer on error path in
> > cpu_cache_level__read function, leading to
> > segfault:
> >
> > (gdb) r record ls
> > Starting program: /root/perf/tools/perf/perf record ls
> > ...
> > [ perf record: Woken up 1 times to write data ]
> > double free or corruption (out)
> >
> > Thread 1 "perf" received signal SIGABRT, Aborted.
> > 0x00007ffff7463798 in raise () from /lib64/power9/libc.so.6
> > (gdb) bt
> > #0 0x00007ffff7463798 in raise () from /lib64/power9/libc.so.6
> > #1 0x00007ffff7443bac in abort () from /lib64/power9/libc.so.6
> > #2 0x00007ffff74af8bc in __libc_message () from /lib64/power9/libc.so.6
> > #3 0x00007ffff74b92b8 in malloc_printerr () from /lib64/power9/libc.so.6
> > #4 0x00007ffff74bb874 in _int_free () from /lib64/power9/libc.so.6
> > #5 0x0000000010271260 in __zfree (ptr=0x7fffffffa0b0) at ../../lib/zalloc..
> > #6 0x0000000010139340 in cpu_cache_level__read (cache=0x7fffffffa090, cac..
> > #7 0x0000000010143c90 in build_caches (cntp=0x7fffffffa118, size=<optimiz..
> > ...
> >
> > Releasing the proper pointer.
>
> You forgot to add:
>
> Fixes: 720e98b5faf1 ("perf tools: Add perf data cache feature")
> Cc: stable@vger.kernel.org: # v4.6+
>
> I did it, please consider doing it next time,
will do, sry
jirka
prev parent reply other threads:[~2019-09-20 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 10:52 [PATCH] perf tools: Fix segfault in cpu_cache_level__read Jiri Olsa
2019-09-20 18:20 ` Arnaldo Carvalho de Melo
2019-09-20 18:44 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920184433.GB26850@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox