From: Tejun Heo <tj@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: Marcin Pawlowski <mpawlowski@fb.com>,
"Williams, Gerald S" <gerald.s.williams@intel.com>,
linux-kernel@vger.kernel.org,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: [PATCH wq/for-5.4-fixes] workqueue: Fix missing kfree(rescuer) in destroy_workqueue()
Date: Fri, 20 Sep 2019 13:43:09 -0700 [thread overview]
Message-ID: <20190920204309.GA2233839@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <1569011160.5576.205.camel@lca.pw>
From 8efe1223d73c218ce7e8b2e0e9aadb974b582d7f Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Fri, 20 Sep 2019 13:39:57 -0700
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Qian Cai <cai@lca.pw>
Fixes: def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")
---
Applied to wq/for-5.4-fixes.
Thanks.
kernel/workqueue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 93e20f5330fc..3f067f1d72e3 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4345,6 +4345,7 @@ void destroy_workqueue(struct workqueue_struct *wq)
/* rescuer will empty maydays list before exiting */
kthread_stop(rescuer->task);
+ kfree(rescuer);
}
/* sanity checks */
--
2.17.1
prev parent reply other threads:[~2019-09-20 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 20:26 "Fix spurious sanity check failures in destroy_workqueue()" introduced memory leaks Qian Cai
2019-09-20 20:43 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920204309.GA2233839@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=cai@lca.pw \
--cc=gerald.s.williams@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpawlowski@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox