From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: ~@devbig004.ftw2.facebook.com,
LKML <linux-kernel@vger.kernel.org>,
kernel-team <kernel-team@fb.com>,
Marcin Pawlowski <mpawlowski@fb.com>,
"Williams, Gerald S" <gerald.s.williams@intel.com>
Subject: Re: [PATCH] workqueue: Fix spurious sanity check failures in destroy_workqueue()
Date: Fri, 20 Sep 2019 14:08:33 -0700 [thread overview]
Message-ID: <20190920210833.GC2233839@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <CAJhGHyBd53ogp35FkmwDhzCv7=MipXwyoHGPVXjsaxSH540O8A@mail.gmail.com>
Hello,
On Thu, Sep 19, 2019 at 10:49:04AM +0800, Lai Jiangshan wrote:
> Looks good to me.
>
> There is one test in show_pwq()
> """
> worker == pwq->wq->rescuer ? "(RESCUER)" : "",
> """
> I'm wondering if it needs to be updated to
> """
> worker->rescue_wq ? "(RESCUER)" : "",
> """
Hmm... yeah, good point. Let's do that.
> And document "/* MD: rescue worker */" might be better
> than current "/* I: rescue worker */", although ->rescuer can
> be accessed without wq_mayday_lock lock in some code.
Will apply this one too.
Thanks.
--
tejun
next prev parent reply other threads:[~2019-09-20 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 1:43 [PATCH] workqueue: Fix spurious sanity check failures in destroy_workqueue() Tejun Heo
2019-09-19 2:49 ` Lai Jiangshan
2019-09-20 21:08 ` Tejun Heo [this message]
2019-09-20 21:12 ` [PATCH] workqueue: Minor follow-ups to the rescuer destruction change Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920210833.GC2233839@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=gerald.s.williams@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpawlowski@fb.com \
--cc=~@devbig004.ftw2.facebook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox