From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CB7C3A5A2 for ; Sun, 22 Sep 2019 19:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F8AB2054F for ; Sun, 22 Sep 2019 19:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569180518; bh=Efrs07DtXo6dlB5edLomXEd/SCJQyQCva1c9N4iPxMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AQA2996vwk9WNkCaaxuhQoUDVG+3xDpIxyAtonm8c2pTWYyPXTbSNfSzsdn8PWYez WzgA9lwPcbgu+MomHN3A7ZtTGBXu7WJ6F9UJmxmx9YMkR/w6esjSVBxSlg93koC7X6 7Yxs8zd8jNZUMrc8zY+mdF6oHGRnJp7z8SKYN5U4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731685AbfIVT2h (ORCPT ); Sun, 22 Sep 2019 15:28:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:47964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728817AbfIVSun (ORCPT ); Sun, 22 Sep 2019 14:50:43 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E5E321479; Sun, 22 Sep 2019 18:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178242; bh=Efrs07DtXo6dlB5edLomXEd/SCJQyQCva1c9N4iPxMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dNvz8qOqzpcazdrnZAC8XQvE8CLECy723U/Nu4bU0XLLhAN/zIrzi5A5JM9o3k/1m xxuiHjlny7kAyYbOkQ3kf1u8DSgML5hSbED/qB10jmHE1/f1HRI9ZaEpUDgwYIdFra qQQrgO1Iqonq9N07+tdUG7GPyif9y8lJCc7a5JNY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ard van Breemen , Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 5.2 037/185] ALSA: usb-audio: Skip bSynchAddress endpoint check if it is invalid Date: Sun, 22 Sep 2019 14:46:55 -0400 Message-Id: <20190922184924.32534-37-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184924.32534-1-sashal@kernel.org> References: <20190922184924.32534-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard van Breemen [ Upstream commit 1b34121d9f26d272b0b2334209af6b6fc82d4bf1 ] The Linux kernel assumes that get_endpoint(alts,0) and get_endpoint(alts,1) are eachothers feedback endpoints. To reassure that validity it will test bsynchaddress to comply with that assumption. But if the bsyncaddress is 0 (invalid), it will flag that as a wrong assumption and return an error. Fix: Skip the test if bSynchAddress is 0. Note: those with a valid bSynchAddress should have a code quirck added. Signed-off-by: Ard van Breemen Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index e4bbf79de956e..33cd26763c0ee 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -457,6 +457,7 @@ static int set_sync_endpoint(struct snd_usb_substream *subs, } ep = get_endpoint(alts, 1)->bEndpointAddress; if (get_endpoint(alts, 0)->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE && + get_endpoint(alts, 0)->bSynchAddress != 0 && ((is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress | USB_DIR_IN)) || (!is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress & ~USB_DIR_IN)))) { dev_err(&dev->dev, -- 2.20.1