* [PATCH] drm/komeda: Fix typos in komeda_splitter_validate
@ 2019-09-20 15:11 Mihail Atanassov
2019-09-23 2:40 ` james qian wang (Arm Technology China)
2019-09-27 12:33 ` Liviu Dudau
0 siblings, 2 replies; 3+ messages in thread
From: Mihail Atanassov @ 2019-09-20 15:11 UTC (permalink / raw)
To: dri-devel@lists.freedesktop.org
Cc: Mihail Atanassov, nd, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
linux-kernel@vger.kernel.org
Fix both the string and the struct member being printed.
Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
index 950235af1e79..de64a6a9964e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
@@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
}
if (!in_range(&splitter->vsize, dflow->in_h)) {
- DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
- dflow->in_w);
+ DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
+ dflow->in_h);
return -EINVAL;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/komeda: Fix typos in komeda_splitter_validate
2019-09-20 15:11 [PATCH] drm/komeda: Fix typos in komeda_splitter_validate Mihail Atanassov
@ 2019-09-23 2:40 ` james qian wang (Arm Technology China)
2019-09-27 12:33 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-09-23 2:40 UTC (permalink / raw)
To: Mihail Atanassov
Cc: dri-devel@lists.freedesktop.org, nd, Liviu Dudau, Brian Starkey,
David Airlie, Daniel Vetter, linux-kernel@vger.kernel.org
Hi Mihail
On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
>
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> }
>
> if (!in_range(&splitter->vsize, dflow->in_h)) {
> - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> - dflow->in_w);
> + DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
> + dflow->in_h);
Thank you for the patch.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> return -EINVAL;
> }
>
> --
> 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/komeda: Fix typos in komeda_splitter_validate
2019-09-20 15:11 [PATCH] drm/komeda: Fix typos in komeda_splitter_validate Mihail Atanassov
2019-09-23 2:40 ` james qian wang (Arm Technology China)
@ 2019-09-27 12:33 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2019-09-27 12:33 UTC (permalink / raw)
To: Mihail Atanassov
Cc: dri-devel@lists.freedesktop.org, nd,
james qian wang (Arm Technology China), Brian Starkey,
David Airlie, Daniel Vetter, linux-kernel@vger.kernel.org
On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
>
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> }
>
> if (!in_range(&splitter->vsize, dflow->in_h)) {
> - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> - dflow->in_w);
> + DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
Being pedandic: s/exceed/exceeds/.
Best regards,
Liviu
> + dflow->in_h);
> return -EINVAL;
> }
>
> --
> 2.23.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-27 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-20 15:11 [PATCH] drm/komeda: Fix typos in komeda_splitter_validate Mihail Atanassov
2019-09-23 2:40 ` james qian wang (Arm Technology China)
2019-09-27 12:33 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox