Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()

Jason Wang
2019-09-25T11:57:35Z

On 2019/9/24 下午10:04, Alex Williamson wrote:
> On Mon, 23 Sep 2019 12:00:41 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> On Mon, Sep 23, 2019 at 09:45:59AM -0600, Alex Williamson wrote:
>>> On Mon, 23 Sep 2019 21:03:30 +0800
>>> Jason Wang <jasowang@redhat.com> wrote:
>>>
>>>> We want to copy from iov to buf, so the direction was wrong.
>>>>
>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>>> ---
>>>> drivers/vhost/vringh.c | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>> Why is this included in the series? Seems like an unrelated fix being
>>> held up within a proposal for a new feature. Thanks,
>>>
>>> Alex
>> It's better to have it as patch 1/6, but it's a dependency of the
>> example driver in the series. I can reorder when I apply.
> It's a fix, please submit it separately through virtio/vhost channels,
> then it will already be in the base kernel we use for the rest of the
> series. The remainder of the series certainly suggests a workflow
> through the vfio tree rather than virtio/vhost. Thanks,
>
> Alex

Ok.

Thanks