From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Kees Cook <keescook@chromium.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: [patch V2 4/6] posix-cpu-timers: Make PID=0 and PID=self handling consistent
Date: Mon, 23 Sep 2019 16:54:39 +0200 [thread overview]
Message-ID: <20190923145528.764987925@linutronix.de> (raw)
In-Reply-To: 20190923145435.507024424@linutronix.de
From: Thomas Gleixner <tglx@linutronix.de>
If the PID encoded into the clock id is 0 then the target is either the
calling thread itself or the process to which it belongs.
If the current thread encodes its own PID on a process wide clock then
there is no reason not to treat it in the same way as the PID=0 case.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
---
V2: Remove the extra same_thread_group() check which is pointless.
---
kernel/time/posix-cpu-timers.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -90,18 +90,20 @@ static struct task_struct *lookup_task(c
} else {
/*
+ * Timer is going to be attached to a process. If p is
+ * current then treat it like the PID=0 case above.
+ * This also avoids the ptrace overhead.
+ */
+ if (p == current)
+ return current->group_leader;
+
+ /*
* Process wide timers need the group leader because they
* take a reference on it and store the task pointer until
* the timer is destroyed.
*/
if (!has_group_leader_pid(p))
return NULL;
-
- /*
- * Avoid the ptrace overhead when this is current's process
- */
- if (same_thread_group(p, current))
- return p;
}
/* Decide based on the ptrace permissions. */
next prev parent reply other threads:[~2019-09-23 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:54 [patch V2 0/6] posix-cpu-timers: Fix bogus permission checks Thomas Gleixner
2019-09-23 14:54 ` [patch V2 1/6] posix-cpu-timers: Restrict timer_create() permissions Thomas Gleixner
2019-09-23 14:54 ` [patch V2 2/6] posix-cpu-timers: Restrict clock_gettime() permissions Thomas Gleixner
2019-09-23 14:54 ` [patch V2 3/6] posix-cpu-timers: Sanitize thread clock permissions Thomas Gleixner
2019-09-23 14:54 ` Thomas Gleixner [this message]
2019-09-23 14:54 ` [patch V2 5/6] posix-cpu-timers: Return PTR_ERR() from lookup_task() Thomas Gleixner
2019-09-23 15:43 ` Frederic Weisbecker
2019-09-23 14:54 ` [patch V2 6/6] posix-cpu-timers: Return -EPERM if ptrace permission check fails Thomas Gleixner
2019-09-23 15:46 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923145528.764987925@linutronix.de \
--to=tglx@linutronix.de \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@googlemail.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox