Re: [PATCH 14/17] KVM: monolithic: x86: inline more exit handlers in vmx.c

Paolo Bonzini
2019-09-25T07:52:59Z

On 24/09/19 03:55, Andrea Arcangeli wrote:
>> So it's forty bytes. I think we can leave this out.
> This commit I reverted adds literally 3 inlines called by 3 functions,
> in a very fast path, how many bytes of .text difference did you expect
> by dropping some call/ret from a very fast path when you asked me to
> test it? I mean it's just a couple of insn each.

Actually I was either expecting the difference to be zero, meaning GCC
was already inlining them.

I think it is not inlining the functions because they are still
referenced by vmx_exit_handlers. After patch 15 you could drop them
from the array, and then GCC should inline them.

Paolo