From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA74C432C1 for ; Tue, 24 Sep 2019 01:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80BCC214DA for ; Tue, 24 Sep 2019 01:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503721AbfIXBBA (ORCPT ); Mon, 23 Sep 2019 21:01:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503707AbfIXBBA (ORCPT ); Mon, 23 Sep 2019 21:01:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49E01308A9E0; Tue, 24 Sep 2019 01:01:00 +0000 (UTC) Received: from mail (ovpn-120-159.rdu2.redhat.com [10.10.120.159]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 835825D713; Tue, 24 Sep 2019 01:00:57 +0000 (UTC) Date: Mon, 23 Sep 2019 21:00:56 -0400 From: Andrea Arcangeli To: Paolo Bonzini Cc: Vitaly Kuznetsov , "Dr. David Alan Gilbert" , Marcelo Tosatti , Peter Xu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/17] KVM: monolithic: x86: inline more exit handlers in vmx.c Message-ID: <20190924010056.GB4658@redhat.com> References: <20190920212509.2578-1-aarcange@redhat.com> <20190920212509.2578-15-aarcange@redhat.com> <6a1d66a1-74c0-25b9-692f-8875e33b2fae@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a1d66a1-74c0-25b9-692f-8875e33b2fae@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 24 Sep 2019 01:01:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 12:19:12PM +0200, Paolo Bonzini wrote: > On 20/09/19 23:25, Andrea Arcangeli wrote: > > They can be called directly more efficiently, so we can as well mark > > some of them inline in case gcc doesn't decide to inline them. > > What is the output of size(1) before and after? Before and after this specific commit there is a difference with gcc 8.3. full patchset applied 753699 87971 9616 851286 cfd56 build/arch/x86/kvm/kvm-intel.ko git revert 753739 87971 9616 851326 cfd7e build/arch/x86/kvm/kvm-intel.ko git reset --hard HEAD^ 753699 87971 9616 851286 cfd56 build/arch/x86/kvm/kvm-intel.ko git revert 753739 87971 9616 851326 cfd7e build/arch/x86/kvm/kvm-intel.ko