From: Dan Carpenter <dan.carpenter@oracle.com>
To: Connor Kuehl <connor.kuehl@canonical.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
straube.linux@gmail.com, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step
Date: Tue, 24 Sep 2019 09:15:16 +0300 [thread overview]
Message-ID: <20190924061200.GK2959@kadam> (raw)
In-Reply-To: <20190923194806.25347-1-connor.kuehl@canonical.com>
On Mon, Sep 23, 2019 at 12:48:06PM -0700, Connor Kuehl wrote:
> @@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *p
> adapt->HalData->LastHMEBoxNum =
> (h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS;
>
> - } while ((!bcmd_down) && (retry_cnts--));
> + } while (!bcmd_down);
Just get rid of the whole do while loop, because it just goes through
one time. It doesn't loop. Get rid of bcmd_down as well.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-24 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 19:48 [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step Connor Kuehl
2019-09-23 20:38 ` Larry Finger
2019-09-23 20:49 ` Connor Kuehl
2019-09-24 6:17 ` Dan Carpenter
2019-09-24 6:15 ` Dan Carpenter [this message]
2019-09-24 14:25 ` NACK: " Connor Kuehl
2019-09-24 15:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924061200.GK2959@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=connor.kuehl@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox