From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1668C432C2 for ; Tue, 24 Sep 2019 06:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A44972146E for ; Tue, 24 Sep 2019 06:18:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Hl0BXNRR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440515AbfIXGSJ (ORCPT ); Tue, 24 Sep 2019 02:18:09 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:35672 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387676AbfIXGSJ (ORCPT ); Tue, 24 Sep 2019 02:18:09 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8O6Dq64032934; Tue, 24 Sep 2019 06:17:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=hiSslqM7TGflYLLAXweDSTEdhwpxT+KQg4juxYzl38k=; b=Hl0BXNRRKIdOjjClw3QwDb/aE+KaFBAVF43XDp9f0uS8VhNIsuJ3GFFmnR4ebulOf1i0 e6RLtqvOXwywXJuDvz2AQz2+JJrADcn7ia28HDRff5hZvbenub2ehknDyhefToHyTYW4 ugcBeKGXPjMLKYNX6ac0LIlaphfP8dsxiGHGF8jXk6YgRm5YHmhW9F+z+Q26X+AgWgII NTW4Ga9bMxqQUKt92ZT68asvHlZa4hmb3gf8y16RVTMixLi+dsdNHSSqQ9pNp1MjpgRG Z2QOKdvzEQusLN6mU3VETTXOaJWOVUhEbgIfYaaH+ROgNeXReTMRyVFYFjHkY+SvZxjM Ww== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2v5btpuq04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Sep 2019 06:17:59 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8O6DRdN030994; Tue, 24 Sep 2019 06:17:58 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2v6yvr07ex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Sep 2019 06:17:58 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x8O6HwY8003871; Tue, 24 Sep 2019 06:17:58 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 23 Sep 2019 23:17:57 -0700 Date: Tue, 24 Sep 2019 09:17:48 +0300 From: Dan Carpenter To: Larry Finger Cc: Connor Kuehl , gregkh@linuxfoundation.org, straube.linux@gmail.com, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step Message-ID: <20190924061748.GA27389@kadam> References: <20190923194806.25347-1-connor.kuehl@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9389 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=957 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909240063 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9389 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909240063 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 03:38:39PM -0500, Larry Finger wrote: > This patch is correct; however, the do..while loop will always be executed s/correct/harmless/. > once, thus you could remove the loop and the loop variable bcmd_down. > > @greg: If you would prefer a two-step process, then this one is OK. It has to be done in one step. regards, dan carpenter