From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E012C4320D for ; Tue, 24 Sep 2019 08:21:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E381214DA for ; Tue, 24 Sep 2019 08:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394927AbfIXIVr (ORCPT ); Tue, 24 Sep 2019 04:21:47 -0400 Received: from mga14.intel.com ([192.55.52.115]:40717 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388712AbfIXIVr (ORCPT ); Tue, 24 Sep 2019 04:21:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 01:21:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,543,1559545200"; d="scan'208";a="193379870" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 24 Sep 2019 01:21:44 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1iCg4t-0006p5-At; Tue, 24 Sep 2019 11:21:43 +0300 Date: Tue, 24 Sep 2019 11:21:43 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: Mika Westerberg , Alex Levin , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions Message-ID: <20190924082143.GS2680@smile.fi.intel.com> References: <20190924024958.GA229906@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190924024958.GA229906@dtor-ws> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 07:49:58PM -0700, Dmitry Torokhov wrote: > This is essentially a revert of: > > e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround > 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0 > > because even with 1.1 versions of BIOS there are some pins that are > configured as interrupts but not claimed by any driver, and they > sometimes fire up and result in interrupt storms that cause touchpad > stop functioning and other issues. > > Given that we are unlikely to qualify another firmware version for a > while it is better to keep the workaround active on all Strago boards. Reviewed-by: Andy Shevchenko > > Reported-by: Alex Levin > Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0") > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c > index 03ec7a5d9d0b..bf049d1bbb87 100644 > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > @@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > }, > }, > { > @@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "HP"), > DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > }, > }, > { > @@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > }, > }, > { > @@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > DMI_MATCH(DMI_PRODUCT_NAME, "Celes"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > }, > }, > {} > -- > 2.23.0.351.gc4317032e6-goog > > > -- > Dmitry -- With Best Regards, Andy Shevchenko