* [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions
@ 2019-09-24 2:49 Dmitry Torokhov
2019-09-24 8:21 ` Andy Shevchenko
2019-10-01 8:34 ` Mika Westerberg
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2019-09-24 2:49 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko
Cc: Alex Levin, Linus Walleij, linux-gpio, linux-kernel
This is essentially a revert of:
e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround
86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
because even with 1.1 versions of BIOS there are some pins that are
configured as interrupts but not claimed by any driver, and they
sometimes fire up and result in interrupt storms that cause touchpad
stop functioning and other issues.
Given that we are unlikely to qualify another firmware version for a
while it is better to keep the workaround active on all Strago boards.
Reported-by: Alex Levin <levinale@chromium.org>
Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 03ec7a5d9d0b..bf049d1bbb87 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "HP"),
DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{}
--
2.23.0.351.gc4317032e6-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions
2019-09-24 2:49 [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions Dmitry Torokhov
@ 2019-09-24 8:21 ` Andy Shevchenko
2019-09-26 0:39 ` Alex Levin
2019-10-01 8:34 ` Mika Westerberg
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2019-09-24 8:21 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Mika Westerberg, Alex Levin, Linus Walleij, linux-gpio,
linux-kernel
On Mon, Sep 23, 2019 at 07:49:58PM -0700, Dmitry Torokhov wrote:
> This is essentially a revert of:
>
> e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround
> 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
>
> because even with 1.1 versions of BIOS there are some pins that are
> configured as interrupts but not claimed by any driver, and they
> sometimes fire up and result in interrupt storms that cause touchpad
> stop functioning and other issues.
>
> Given that we are unlikely to qualify another firmware version for a
> while it is better to keep the workaround active on all Strago boards.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reported-by: Alex Levin <levinale@chromium.org>
> Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 03ec7a5d9d0b..bf049d1bbb87 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {}
> --
> 2.23.0.351.gc4317032e6-goog
>
>
> --
> Dmitry
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions
2019-09-24 8:21 ` Andy Shevchenko
@ 2019-09-26 0:39 ` Alex Levin
0 siblings, 0 replies; 4+ messages in thread
From: Alex Levin @ 2019-09-26 0:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dmitry Torokhov, Mika Westerberg, Linus Walleij, linux-gpio,
linux-kernel
On Tue, Sep 24, 2019 at 1:21 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Sep 23, 2019 at 07:49:58PM -0700, Dmitry Torokhov wrote:
> > This is essentially a revert of:
> >
> > e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround
> > 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
> >
> > because even with 1.1 versions of BIOS there are some pins that are
> > configured as interrupts but not claimed by any driver, and they
> > sometimes fire up and result in interrupt storms that cause touchpad
> > stop functioning and other issues.
> >
> > Given that we are unlikely to qualify another firmware version for a
> > while it is better to keep the workaround active on all Strago boards.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Alex Levin <levinale@chromium.org>
>
> >
> > Reported-by: Alex Levin <levinale@chromium.org>
> > Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> > index 03ec7a5d9d0b..bf049d1bbb87 100644
> > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> > @@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> > DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
> > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> > },
> > },
> > {
> > @@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> > DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
> > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> > },
> > },
> > {
> > @@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> > DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
> > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> > },
> > },
> > {
> > @@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> > DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
> > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> > },
> > },
> > {}
> > --
> > 2.23.0.351.gc4317032e6-goog
> >
> >
> > --
> > Dmitry
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions
2019-09-24 2:49 [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions Dmitry Torokhov
2019-09-24 8:21 ` Andy Shevchenko
@ 2019-10-01 8:34 ` Mika Westerberg
1 sibling, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2019-10-01 8:34 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andy Shevchenko, Alex Levin, Linus Walleij, linux-gpio,
linux-kernel
On Mon, Sep 23, 2019 at 07:49:58PM -0700, Dmitry Torokhov wrote:
> This is essentially a revert of:
>
> e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround
> 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
>
> because even with 1.1 versions of BIOS there are some pins that are
> configured as interrupts but not claimed by any driver, and they
> sometimes fire up and result in interrupt storms that cause touchpad
> stop functioning and other issues.
>
> Given that we are unlikely to qualify another firmware version for a
> while it is better to keep the workaround active on all Strago boards.
>
> Reported-by: Alex Levin <levinale@chromium.org>
> Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied to intel.git/fixes, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-01 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-24 2:49 [PATCH] pinctrl: cherryview: restore Strago DMI workaround for all versions Dmitry Torokhov
2019-09-24 8:21 ` Andy Shevchenko
2019-09-26 0:39 ` Alex Levin
2019-10-01 8:34 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox