From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0725C432C1 for ; Tue, 24 Sep 2019 16:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFEF2217D9 for ; Tue, 24 Sep 2019 16:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343850; bh=NpFt4VysNHZNSD9PF2n48smfBRcHUrmddrU3O6zZY+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UaTHXqRaHl97E01XY6sK8iyG2UvzC6rbOG8/hC9xLzRe/v3nMzK+mt8ing5Glvadh VY5mcyrqPX+34czVtVHFWHB5cQ2GdMukPmDZRoWZSArFUnrNOGutw0gbYinS8rzFQc rhy8WD/JYsbBrjt+bSD0plPUb2cbHcDWEz7BGx1k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441501AbfIXQut (ORCPT ); Tue, 24 Sep 2019 12:50:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:43622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436521AbfIXQul (ORCPT ); Tue, 24 Sep 2019 12:50:41 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0E3D217D9; Tue, 24 Sep 2019 16:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343840; bh=NpFt4VysNHZNSD9PF2n48smfBRcHUrmddrU3O6zZY+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmD/l5CA0FaJohJ3xIrydsaW+iFWONJzJ3Lp42Mq6Aneoga0/Jj1yTU9yXBrGh9fY qeBuq8Tbk37hEkLqARSyEkFkeSDw4xrr/iYvkxEtKS9slGw3JF77VR9C2w+aTW8g0i I/kp5OIqUf2ykeoF4sxKvu3l+uAhf3iumxKz5ipQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marko Kohtala , Mark Rutland , Rob Herring , Daniel Vetter , David Airlie , =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= , Bartlomiej Zolnierkiewicz , Sasha Levin , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 04/28] video: ssd1307fb: Start page range at page_offset Date: Tue, 24 Sep 2019 12:50:07 -0400 Message-Id: <20190924165031.28292-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190924165031.28292-1-sashal@kernel.org> References: <20190924165031.28292-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marko Kohtala [ Upstream commit dd9782834dd9dde3624ff1acea8859f3d3e792d4 ] The page_offset was only applied to the end of the page range. This caused the display updates to cause a scrolling effect on the display because the amount of data written to the display did not match the range display expected. Fixes: 301bc0675b67 ("video: ssd1307fb: Make use of horizontal addressing mode") Signed-off-by: Marko Kohtala Cc: Mark Rutland Cc: Rob Herring Cc: Daniel Vetter Cc: David Airlie Cc: Michal Vokáč Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20190618074111.9309-4-marko.kohtala@okoko.fi Signed-off-by: Sasha Levin --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index f599520374ddf..5f7dbf1c46092 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -433,7 +433,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, 0x0); + ret = ssd1307fb_write_cmd(par->client, par->page_offset); if (ret < 0) return ret; -- 2.20.1