From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB667C432C1 for ; Tue, 24 Sep 2019 21:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9619B20872 for ; Tue, 24 Sep 2019 21:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OFC1szf5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439146AbfIXVwo (ORCPT ); Tue, 24 Sep 2019 17:52:44 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40245 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728183AbfIXVwo (ORCPT ); Tue, 24 Sep 2019 17:52:44 -0400 Received: by mail-pf1-f194.google.com with SMTP id x127so2111905pfb.7 for ; Tue, 24 Sep 2019 14:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+fhJ9T/vZjSSX05VHp18SVR0XFnj5tZksc8z2VAuz54=; b=OFC1szf5PoQuT5vyg4Il+WGjsj/nKDC3/5I83EXRYroN4p+0LcCQNVXZ1Dczng+l/9 mX0OgMcBO2ic+gGiP5KR3IqB8DXh9UeF13m6c15qdDEuA7foGI5jv2h6XOlk7iSwSAww 9xyXErYkzTDlxbmY4plb2PXQnB5uWqu/47bX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+fhJ9T/vZjSSX05VHp18SVR0XFnj5tZksc8z2VAuz54=; b=KomZ5MTpBG2pD3nLB8k02Atmlddt4ccZbpYkFu7rT1NlTymo5J+LVvq0Rz28LIXwxF echRIo4OKbLubOIH+i+sNcLG8mYw0A8FPmjuNqGCtm5rUrSS7ZfLuad6bEYtzT1qgLc5 hhZJwaCnsf9EOPdfR8p2B0FOFRXCz+x3Y8/xFNy4i3ao/xQuEuptCdNz0WYi/f0FhmrA stE4U+iMBMwZP2rj4/z3dq6a535F/YNz2GXGr6PUF+4QHpai4gvFFjNSCirCJIJ75jng nRZ2FrX4bA5E5GQIwnQDfw5EapIcXvTAWGbFP9P3rgVuzrc55m4cDPRBCF6/BR17vYkW 4DqA== X-Gm-Message-State: APjAAAULSIOYuu6u3LyPm9OgAU5n6nRl4DJJHV9yn/qmBVkCktifUhbU q/M3hrUvFBI477Uz33MOEzMcZQ== X-Google-Smtp-Source: APXvYqwWBdF0lQs3EbGKhbUaeNBDEuDBk7pm4dNkAF2JHWwebTmEQlp77C87FjqJ6npYTny70kzyBA== X-Received: by 2002:a63:a548:: with SMTP id r8mr4828285pgu.401.1569361963764; Tue, 24 Sep 2019 14:52:43 -0700 (PDT) Received: from evgreen2.mtv.corp.google.com ([2620:15c:202:201:ffda:7716:9afc:1301]) by smtp.gmail.com with ESMTPSA id q204sm2494493pfc.11.2019.09.24.14.52.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Sep 2019 14:52:43 -0700 (PDT) From: Evan Green To: Nick Dyer , Dmitry Torokhov Cc: Jongpil Jung , Furquan Shaikh , Rajat Jain , Evan Green , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v2] Input: atmel_mxt_ts - Disable IRQ across suspend Date: Tue, 24 Sep 2019 14:52:38 -0700 Message-Id: <20190924215238.184750-1-evgreen@chromium.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Across suspend and resume, we are seeing error messages like the following: atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121) atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121) This occurs because the driver leaves its IRQ enabled. Upon resume, there is an IRQ pending, but the interrupt is serviced before both the driver and the underlying I2C bus have been resumed. This causes EREMOTEIO errors. Disable the IRQ in suspend, and re-enable it on resume. If there are cases where the driver enters suspend with interrupts disabled, that's a bug we should fix separately. Signed-off-by: Evan Green --- Changes in v2: - Enable and disable unconditionally (Dmitry) drivers/input/touchscreen/atmel_mxt_ts.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 24c4b691b1c9..a58092488679 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -3155,6 +3155,7 @@ static int __maybe_unused mxt_suspend(struct device *dev) mxt_stop(data); mutex_unlock(&input_dev->mutex); + disable_irq(data->irq); return 0; } @@ -3174,6 +3175,7 @@ static int __maybe_unused mxt_resume(struct device *dev) mxt_start(data); mutex_unlock(&input_dev->mutex); + enable_irq(data->irq); return 0; } -- 2.21.0