From: Eryu Guan <guaneryu@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Zhihao Cheng <chengzhihao1@huawei.com>,
David Oberhollenzer <david.oberhollenzer@sigma-star.at>,
Eric Biggers <ebiggers@google.com>,
"zhangyi (F)" <yi.zhang@huawei.com>,
fstests <fstests@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH xfstests v3] overlay: Enable character device to be the base fs partition
Date: Wed, 25 Sep 2019 17:29:13 +0800 [thread overview]
Message-ID: <20190925092913.GR2622@desktop> (raw)
In-Reply-To: <CAOQ4uxjfko0+G_BUOt=fL1iTXdnWA=-=Kn-bgszF08g7yj4zqQ@mail.gmail.com>
On Wed, Sep 25, 2019 at 10:18:39AM +0300, Amir Goldstein wrote:
> On Wed, Sep 25, 2019 at 9:29 AM Zhihao Cheng <chengzhihao1@huawei.com> wrote:
> >
> > When running overlay tests using character devices as base fs partitions,
> > all overlay usecase results become 'notrun'. Function
> > '_overay_config_override' (common/config) detects that the current base
> > fs partition is not a block device and will set FSTYP to base fs. The
> > overlay usecase will check the current FSTYP, and if it is not 'overlay'
> > or 'generic', it will skip the execution.
> >
> > For example, using UBIFS as base fs skips all overlay usecases:
> >
> > FSTYP -- ubifs # FSTYP should be overridden as 'overlay'
> > MKFS_OPTIONS -- /dev/ubi0_1 # Character device
> > MOUNT_OPTIONS -- -t ubifs /dev/ubi0_1 /tmp/scratch
> >
> > overlay/001 [not run] not suitable for this filesystem type: ubifs
> > overlay/002 [not run] not suitable for this filesystem type: ubifs
> > overlay/003 [not run] not suitable for this filesystem type: ubifs
> >
> > When checking that the base fs partition is a block/character device,
> > FSTYP is overwritten as 'overlay'. This patch allows the base fs
> > partition to be a character device that can also execute overlay
> > usecases (such as ubifs).
> >
> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>
> Looks fine.
> Eryu, you may change this to Reviewed-by
Sure, thanks for the review!
Eryu
prev parent reply other threads:[~2019-09-25 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 6:35 [PATCH xfstests v3] overlay: Enable character device to be the base fs partition Zhihao Cheng
2019-09-25 7:18 ` Amir Goldstein
2019-09-25 9:29 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925092913.GR2622@desktop \
--to=guaneryu@gmail.com \
--cc=amir73il@gmail.com \
--cc=chengzhihao1@huawei.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox