Re: [PATCH v2] mtd: onenand: prevent memory leak in onenand_scan

Markus Elfring
2019-10-05T14:04:51Z

> In onenand_scan if scan_bbt fails the allocated buffers for oob_buf,
> verify_buf, and page_buf should be released.

Can a wording like the following be nicer for the change description?

Release the memory for the buffers “oob_buf”, “verify_buf” and “page_buf”
after a call of the function “scan_bbt” failed in the implementation
of the function “onenand_scan”.

> Fixes: 5988af231978 ("mtd: Flex-OneNAND support")
…
> ---
> Changes in v2:
…
> for the hint).

Did you take another review comment into account for this patch change log?

> ---

Please replace the delimiter at this place by a blank line in subsequent messages.

> drivers/mtd/nand/onenand/onenand_base.c | 8 +++++++-
…

Regards,
Markus