From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CEEC432C2 for ; Thu, 26 Sep 2019 00:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88F0A21D6C for ; Thu, 26 Sep 2019 00:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569458156; bh=dVyZPjQRfv3xE5/V0kqvWWL9NliAit4cOL5rMsrTlys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QFx3r+v/z8eO+7FiEjSvzW7Cv9DO42blQblej+pwpuTPcI8OyBp+Dk8PD5odndwlp m7SgpnmNejxIPaBZL8whx+7VO3nJIrOqie3VKEDEXB/1yp7buP0utSgK1K5uG4vPu/ LYYNarwrQUSvdpmxqulCg/RUn2WPVWKqs2NCm+cY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390111AbfIZAfy (ORCPT ); Wed, 25 Sep 2019 20:35:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:38574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390002AbfIZAft (ORCPT ); Wed, 25 Sep 2019 20:35:49 -0400 Received: from quaco.localdomain (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22D67222C3; Thu, 26 Sep 2019 00:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569458148; bh=dVyZPjQRfv3xE5/V0kqvWWL9NliAit4cOL5rMsrTlys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xedUBjDA1GS6N1Ezms3bKodD7WVLWlxTUFZJiqRLhKa6KmtLT0TU5K+/KS8VRcDi2 fbxKDzNC445jf4BcBdOeHnkZpslugr6WZ9iYqRq9HSqEr0FCSh3KDrqbnq5PYeqfyp 7YPDtZvRLugRZ5lqJ8UMDXvFpPnV+KluS8eIlXsU= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter Subject: [PATCH 47/66] perf tools: No need to include internal/lib.h from util/util.h Date: Wed, 25 Sep 2019 21:32:25 -0300 Message-Id: <20190926003244.13962-48-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190926003244.13962-1-acme@kernel.org> References: <20190926003244.13962-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo That was done just to have users of writen() and readn(), that before had their prototypes in util/util.h to get it without having to add an include for internal/lib.h, but the right way is to add it and by now all places already do it. Fix a fallout were readlink() was used but unistd.h was being obtained by luck thru util.h -> internal/lib.h, now to check why unistd.h is being included there... Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-lcnytgrtafey3kwlfog2rzzj@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/sdt.c | 1 + tools/perf/util/util.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c index cf1bd57d3023..60f0e9ee04fb 100644 --- a/tools/perf/tests/sdt.c +++ b/tools/perf/tests/sdt.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h index d6ae394e67c4..b78b73e5bb32 100644 --- a/tools/perf/util/util.h +++ b/tools/perf/util/util.h @@ -11,7 +11,6 @@ #include #include #include -#include /* General helper functions */ void usage(const char *err) __noreturn; -- 2.21.0