From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: amd: acp3x: clean up an indentation issue
Date: Fri, 27 Sep 2019 17:27:36 +0300 [thread overview]
Message-ID: <20190927142552.GH27389@kadam> (raw)
In-Reply-To: <729ae953-b78a-9452-e8b3-3583a21a1295@canonical.com>
On Fri, Sep 27, 2019 at 11:43:31AM +0100, Colin Ian King wrote:
> On 27/09/2019 11:38, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is a return statement that is indented too deeply, remove
> > the extraneous tab.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
> > index bc4dfafdfcd1..ea57088d50ce 100644
> > --- a/sound/soc/amd/raven/acp3x-pcm-dma.c
> > +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
> > @@ -631,7 +631,7 @@ static int acp3x_audio_probe(struct platform_device *pdev)
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > if (!res) {
> > dev_err(&pdev->dev, "IORESOURCE_IRQ FAILED\n");
> > - return -ENODEV;
> > + return -ENODEV;
> > }
> >
> > adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
> >
> Oops, I've sent this fix before. ignore. apologies.
Haha. I used to do this all the time. Now my QC script searches my
outbox. I still send duplicates sometimes if I'm travelling and forget
to copy my outbox over.
regards,
dan carpenter
prev parent reply other threads:[~2019-09-27 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:38 [PATCH] ASoC: amd: acp3x: clean up an indentation issue Colin King
2019-09-27 10:43 ` Colin Ian King
2019-09-27 14:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927142552.GH27389@kadam \
--to=dan.carpenter@oracle.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox