From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BC5C4360C for ; Fri, 27 Sep 2019 15:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 861A7217D7 for ; Fri, 27 Sep 2019 15:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727542AbfI0PdK (ORCPT ); Fri, 27 Sep 2019 11:33:10 -0400 Received: from mga17.intel.com ([192.55.52.151]:51426 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfI0PdK (ORCPT ); Fri, 27 Sep 2019 11:33:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 08:33:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="194521052" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 27 Sep 2019 08:33:05 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1iDsEy-0001S5-2b; Fri, 27 Sep 2019 18:33:04 +0300 Date: Fri, 27 Sep 2019 18:33:04 +0300 From: Andy Shevchenko To: Cezary Rojewski Cc: Pierre-Louis Bossart , Navid Emamdoost , emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids Message-ID: <20190927153304.GS32742@smile.fi.intel.com> References: <20190925161922.22479-1-navid.emamdoost@gmail.com> <13f4bd40-dbaa-e24e-edca-4b4acff9d9c5@linux.intel.com> <20190927025526.GD22969@cs-dulles.cs.umn.edu> <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote: > I'm fine with solution #1 as I guess asking to wait for refactor is not an > option. Code deployment is delayed due to range of administrative decisions, > some of which should be uncovered on alsa-devel soon enough. The problem with solution #1 is freeing orphaned pointer. It will work, but it's simple is not okay from object life time prospective. -- With Best Regards, Andy Shevchenko